Add branches method for AST::CaseMatchNode
#192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
|
@marcandre I'd like to use this PR's feature in rubocop/rubocop#9930. Can you review, merge, and release? |
marcandre
reviewed
Jul 14, 2021
koic
force-pushed
the
add_branches_method_for_ast_case_match_node
branch
from
5926ade
to
72605ab
Compare
This PR adds `branches` method for `AST::CaseMatchNode`. This makes a method similar to `AST::CaseNode#branches` available in `AST::CaseMatchNode`. After this, I will be developing with this API on RuboCop.
koic
force-pushed
the
add_branches_method_for_ast_case_match_node
branch
from
72605ab
to
5e917b1
Compare
|
Thanks @koic! |
|
@marcandre Thank you always! |
koic
added a commit
to koic/rubocop
that referenced
this pull request
Jul 14, 2021
This PR supports Ruby 2.7's pattern matching for `Lint/DuplicateBranch`. And this PR uses rubocop/rubocop-ast#192 feature, so it requires RuboCop AST 1.8.0 or higher.
bbatsov
pushed a commit
to rubocop/rubocop
that referenced
this pull request
Jul 19, 2021
This PR supports Ruby 2.7's pattern matching for `Lint/DuplicateBranch`. And this PR uses rubocop/rubocop-ast#192 feature, so it requires RuboCop AST 1.8.0 or higher.
thearjunmdas
pushed a commit
to thearjunmdas/rubocop
that referenced
this pull request
Aug 20, 2021
This PR supports Ruby 2.7's pattern matching for `Lint/DuplicateBranch`. And this PR uses rubocop/rubocop-ast#192 feature, so it requires RuboCop AST 1.8.0 or higher.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
branchesmethod forAST::CaseMatchNode.This makes a method similar to
AST::CaseNode#branchesavailable inAST::CaseMatchNode.After this, I will be developing with this API on RuboCop.